Re: [PATCH] Error Page code upgrades

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Wed, 23 Jul 2008 14:28:36 +1200 (NZST)

> Well if you read his patch, he's going slightly further than just
> converting ErrorState to a class..
>

I think things have got a little confused. Since I'm submitting three
interlinked things.

To simplify this whole discussion and make the patches easier to audit. I
have now committed the pure class shuffling. It didn't need a vote anyway.

Whats left is the translation tarball'ing (dist) and the code feature
(--enable-auto-locale) to make us of those. I'll post the updated patches
for those again tonight with as many of your suggestions included as seem
reasonable for this release.

We can continue discussion in separate thread for each update and
regarding only the particular patch.

Amos

>
>
>
> Adrian
>
> 2008/7/23 Henrik Nordstrom <henrik_at_henriknordstrom.net>:
>> On tis, 2008-07-22 at 16:19 +0800, Adrian Chadd wrote:
>>
>>> Sure, but my point still stands, sort out the translation -> static
>>> file stuff first, then convert ErrorState to a class without trying to
>>> do auto-translation/charset encoding after the release cycle.
>>>
>>> The first couple are no-brainers - they should end up with a
>>> distribution tarball and functionality matching the current. Worry
>>> about trickery after the release cycle and once some more
>>> planning/design/thought has been done.
>>
>> Yes, and is exacly what is being done by Amos.
>>
>> Only thinking aloud on what the next goals may look like.
>>
>> Regards
>> Henrik
>>
>
Received on Wed Jul 23 2008 - 02:28:40 MDT

This archive was generated by hypermail 2.2.0 : Wed Jul 23 2008 - 12:00:07 MDT