On 06/16/2009 09:57 PM, Mark Nottingham wrote:
> Thanks. Anybody else have a second to look?
Please s/fwdStartFoo/fwdContinue/ and document what it is. Since this is
Squid2 you do not have to do it, of course.
Your cbdata and request manipulations appear technically correct to me.
IMHO, the temporary lack of requestLink is poor style that will be
dangerous for future code modifications.
Cheers,
Alex.
> On 11/06/2009, at 11:28 PM, Amos Jeffries wrote:
>
>> Mark Nottingham wrote:
>>> Would someone mind taking a quick look at this patch:
>>> http://www.squid-cache.org/bugs/attachment.cgi?id=1989
>>> and telling me if I've royally stuffed up with managing fwdState and
>>> request linking?
>>> It's to make miss_access a slow lookup...
>>
>> Looks okay to these uneducated eyes. Probably best to wait for
>> someone else to double-check before a HEAD commit, but IMO it looks
>> good enough for a patching.
>>
>> This one is long-awaited by many. Thanks.
>>
>> Amos
>> --
>> Please be using
>> Current Stable Squid 2.7.STABLE6 or 3.0.STABLE15
>> Current Beta Squid 3.1.0.8 or 3.0.STABLE16-RC1
>
> --
> Mark Nottingham mnot_at_yahoo-inc.com
>
Received on Fri Jun 26 2009 - 17:06:04 MDT
This archive was generated by hypermail 2.2.0 : Mon Jun 29 2009 - 12:00:05 MDT