Re: [PATCH] log virgin HTTP request headers

> On Thu, 2010-01-28 at 09:09 -0700, Alex Rousskov wrote:
>> On 01/28/2010 06:07 AM, Robert Collins wrote:
>> > Just a small thing: can I suggest s/virgin/pristine/ ? Or
>> > s/virgin/received/ ?
>>
>> Pristine may work, but we (and other adaptation related documents) use
>> virgin in many places already, including APIs.
>>
>> Received is a bad idea because an adapted message is also received.
>>
>> > virgin has a sexual connotation in some cultures, and can be confusing
>> > in a way that is avoidable.
>>
>> Tell that to the Virgin Islands folks. :-)
>
> It was a passing thought, I'm not like 'omg must be done' for this: I
> certainly knew what it meant, but as its (AFAIK) the first config option
> in squid to specify virgins, I see potential for confusion :) Other
> possibilities:
> - source
> - external
> - unaltered
> - original

Yep, I think we should use "original" for documentation.
But for code requires many changes in many places...

>
> I don't know that the config option has to meet the code, though
> obviously it is nice if it does.
>
> -Rob
>
Received on Fri Jan 29 2010 - 12:04:57 MST